----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112188/#review38338 -----------------------------------------------------------
This review has been submitted with commit fb28de93e26b6c24a9667a16b21259e1737b3d25 by Dan Vrátil to branch kde-telepathy-0.6. - Commit Hook On Aug. 22, 2013, 12:35 p.m., Dan Vrátil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112188/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2013, 12:35 p.m.) > > > Review request for Telepathy. > > > Description > ------- > > When LogsImporter is deleted, it just deletes the importer thread even when > it's running, which will obviously crash. > > This patch adds a safety guard (calling QThread::wait() before deleting it) > and a method to stop the thread prematurely so that we don't wait() for the > entire import to finish (just for current document to finish). > > > Diffs > ----- > > KTp/logs-importer.cpp 926d265 > KTp/logs-importer-private.h 06c9c0d > KTp/logs-importer-private.cpp 7275b07 > > Diff: http://git.reviewboard.kde.org/r/112188/diff/ > > > Testing > ------- > > > Thanks, > > Dan Vrátil > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
