> On Sept. 2, 2013, 12:38 p.m., David Edmundson wrote: > > plugins/pintxo/main-options-widget.ui, lines 26-28 > > <http://git.reviewboard.kde.org/r/112438/diff/4/?file=186258#file186258line26> > > > > The label is called "Account Name:" > > yet the code refers to it as "number". > > > > What does the user enter here, and how is this parameter used?
It is the name of the account that the user would like to see in contact-list. I had initially set the label as "Your phone number", but saw no point in limiting the user to just numbers. The CM uses the "number" param as the id/number for the self-handle, nothing else. - Anant ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112438/#review39145 ----------------------------------------------------------- On Sept. 2, 2013, 3:28 a.m., Anant Kamath wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112438/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2013, 3:28 a.m.) > > > Review request for Telepathy and David Edmundson. > > > Description > ------- > > Merge plugin for the SMS connection manager (pintxo) > > > Diffs > ----- > > data/profiles/sms.profile PRE-CREATION > plugins/CMakeLists.txt b2af316891af14232c5aaa3eebcfd17802c6a1ca > plugins/pintxo/CMakeLists.txt PRE-CREATION > plugins/pintxo/Messages.sh PRE-CREATION > plugins/pintxo/ktpaccountskcm_plugin_pintxo.desktop.cmake PRE-CREATION > plugins/pintxo/main-options-widget.h PRE-CREATION > plugins/pintxo/main-options-widget.cpp PRE-CREATION > plugins/pintxo/main-options-widget.ui PRE-CREATION > plugins/pintxo/modem-combobox.h PRE-CREATION > plugins/pintxo/modem-combobox.cpp PRE-CREATION > plugins/pintxo/pintxo-account-ui-plugin.h PRE-CREATION > plugins/pintxo/pintxo-account-ui-plugin.cpp PRE-CREATION > plugins/pintxo/pintxo-account-ui.h PRE-CREATION > plugins/pintxo/pintxo-account-ui.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/112438/diff/ > > > Testing > ------- > > Builds, works > > > File Attachments > ---------------- > > Screenshot > http://git.reviewboard.kde.org/media/uploaded/files/2013/09/02/am1.jpeg > > > Thanks, > > Anant Kamath > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
