----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112438/#review39204 -----------------------------------------------------------
plugins/pintxo/CMakeLists.txt <http://git.reviewboard.kde.org/r/112438/#comment28913> Actually I'd rather we make it so that we don't have modem manager we simply skip building this one plugin rather than fatal completely.. Ship it now, and we can change it later. - David Edmundson On Sept. 2, 2013, 6:09 p.m., Anant Kamath wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112438/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2013, 6:09 p.m.) > > > Review request for Telepathy and David Edmundson. > > > Description > ------- > > Merge plugin for the SMS connection manager (pintxo) > > > Diffs > ----- > > data/profiles/sms.profile PRE-CREATION > plugins/CMakeLists.txt b2af316891af14232c5aaa3eebcfd17802c6a1ca > plugins/pintxo/CMakeLists.txt PRE-CREATION > plugins/pintxo/Messages.sh PRE-CREATION > plugins/pintxo/ktpaccountskcm_plugin_pintxo.desktop.cmake PRE-CREATION > plugins/pintxo/main-options-widget.h PRE-CREATION > plugins/pintxo/main-options-widget.cpp PRE-CREATION > plugins/pintxo/main-options-widget.ui PRE-CREATION > plugins/pintxo/modem-combobox.h PRE-CREATION > plugins/pintxo/modem-combobox.cpp PRE-CREATION > plugins/pintxo/pintxo-account-ui-plugin.h PRE-CREATION > plugins/pintxo/pintxo-account-ui-plugin.cpp PRE-CREATION > plugins/pintxo/pintxo-account-ui.h PRE-CREATION > plugins/pintxo/pintxo-account-ui.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/112438/diff/ > > > Testing > ------- > > Builds, works > > > File Attachments > ---------------- > > Screenshot > http://git.reviewboard.kde.org/media/uploaded/files/2013/09/02/am1.jpeg > > > Thanks, > > Anant Kamath > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
