----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107345/#review40467 -----------------------------------------------------------
This review has been submitted with commit 92483aa86f38a20ef97877a69c70f1b5da309805 by David Edmundson on behalf of Martin Klapetek to branch nepomuk-feeder. - Commit Hook On Nov. 16, 2012, 5:27 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107345/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2012, 5:27 p.m.) > > > Review request for Telepathy and Vishesh Handa. > > > Description > ------- > > The feeder was using the streamedMedia..(..) calls to detected capabilities, > but these are deprecated now with Call1. This copies the capabilities > detection from AccountsModel/ContactsModel, so the feeder actually feeds > proper informations. > > > Diffs > ----- > > capabilities-hack-private.h PRE-CREATION > CMakeLists.txt aa0907f > abstract-storage.h b6aa32e > account.h 0cac18c > account.cpp 4fef2b2 > capabilities-hack-private.cpp PRE-CREATION > contact.h e8d7044 > contact.cpp 9bc953d > controller.cpp 8e7dcf8 > nepomuk-storage.h 05c6acb > nepomuk-storage.cpp 25d432d > > Diff: http://git.reviewboard.kde.org/r/107345/diff/ > > > Testing > ------- > > Capabilities are properly detected, however they are not properly stored in > Nepomuk. I've checked all the code and it all looks fine, so it must be with > the graph saving. Here's a scenairo where it fails: > > 1. Contact is online in some client, only text capability is available > 2. Contact switches clients/logs in some other client with audio/video caps > 3. Capabilities are properly detected, properly placed in the resource, > pushed into the graph > 3.1. With text capability, there is now also audio and video capabilities in > the resource > 4. After pushing it, Nepomuk contains only the audio & video capabilities, > the text one is gone > 5. If the capabilities change again (tested with back to text-only), it > updates properly in Nepomuk > > Vishesh, do you have any idea what might be wrong here? > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
