----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107385/#review40466 -----------------------------------------------------------
This review has been submitted with commit 43d411b11b4196dcd2c7bcfd74593266c5dfbac5 by David Edmundson on behalf of Martin Klapetek to branch nepomuk-feeder. - Commit Hook On Nov. 19, 2012, 2:56 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107385/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2012, 2:56 p.m.) > > > Review request for Telepathy and Vishesh Handa. > > > Description > ------- > > The presenceChanged(..) signal is never emitted (bug in tp-qt?) when the > account disconnects and so Nepomuk is left with invalid contact presences. > This sets all contacts to offline when the connection drops. The presence is > re-set when the account is online thanks to the presenceChanged(..) being > emitted for all contacts. > > > Diffs > ----- > > contact.h e8d7044 > contact.cpp 9bc953d > > Diff: http://git.reviewboard.kde.org/r/107385/diff/ > > > Testing > ------- > > Disabling an account sets all contacts as offline. Reenabling it sets them to > their presence (though a bit delayed, we might want to tweak this). > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
