----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114670/#review46188 -----------------------------------------------------------
src/metacontact.cpp <https://git.reviewboard.kde.org/r/114670/#comment32983> Put a space before "!" src/metacontact.cpp <https://git.reviewboard.kde.org/r/114670/#comment32986> insertContact() calls reaload() itself, it's probably not necessary to do it twice? Also since reload() looks expensive, maybe you don't want to call it for every insertContact(), but just once after? src/metacontact.cpp <https://git.reviewboard.kde.org/r/114670/#comment32987> insertContact() calls reload(), see my comment above. src/personsmodel.cpp <https://git.reviewboard.kde.org/r/114670/#comment32985> s/practive/practice/ Also: if I understand it correctly, personChanged() emits notification about change of the parent row of the rows just inserted. So it makes sense to call personChanged() after endInsertRows(), which ensures the new rows are already in the view. I think the code is just fine and the NOTE is not neccesary. - Dan Vrátil On Dec. 26, 2013, 4:10 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114670/ > ----------------------------------------------------------- > > (Updated Dec. 26, 2013, 4:10 p.m.) > > > Review request for Telepathy. > > > Repository: libkpeople > > > Description > ------- > > Make sure we emit the correct subcontact model index when > adding/removing/changing subcontacts > > > Diffs > ----- > > src/metacontact.cpp 92d4e61 > src/metacontact_p.h 7b36773 > src/personsmodel.cpp c447730 > > Diff: https://git.reviewboard.kde.org/r/114670/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
