----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114670/#review46268 -----------------------------------------------------------
Ship it! src/metacontact.cpp <https://git.reviewboard.kde.org/r/114670/#comment33028> Still no space before "!" ;) src/metacontact.cpp <https://git.reviewboard.kde.org/r/114670/#comment33030> "& " -> " &" (look for more) src/metacontact.cpp <https://git.reviewboard.kde.org/r/114670/#comment33029> I believe this should be insertContactInternal()? src/metacontact.cpp <https://git.reviewboard.kde.org/r/114670/#comment33031> You can do just if (d->contactIds.contains(contactId)) here, imho a clearer code (also no need for the index var up here; the "return index" can be moved to the else branch) src/metacontact_p.h <https://git.reviewboard.kde.org/r/114670/#comment33032> &s to the right - Martin Klapetek On Dec. 27, 2013, 10:30 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114670/ > ----------------------------------------------------------- > > (Updated Dec. 27, 2013, 10:30 p.m.) > > > Review request for Telepathy. > > > Repository: libkpeople > > > Description > ------- > > Make sure we emit the correct subcontact model index when > adding/removing/changing subcontacts > > > Diffs > ----- > > src/metacontact.cpp 92d4e61 > src/metacontact_p.h 7b36773 > src/personsmodel.cpp c447730 > > Diff: https://git.reviewboard.kde.org/r/114670/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
