> On Dec. 30, 2013, 10:32 a.m., Martin Klapetek wrote: > > plugins/sipe/sipe-account-ui-plugin.cpp, line 48 > > <https://git.reviewboard.kde.org/r/114121/diff/2/?file=227217#file227217line48> > > > > This should be parented
I found that the only one plugin have AccountUi parented - gabble, anyway added it for sipe - Maksim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114121/#review46433 ----------------------------------------------------------- On Dec. 31, 2013, 12:19 p.m., Maksim Melnikau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114121/ > ----------------------------------------------------------- > > (Updated Dec. 31, 2013, 12:19 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-accounts-kcm > > > Description > ------- > > telepathy-sipe e.g. pidgin-sipe telepathy's backend support > > > Diffs > ----- > > plugins/CMakeLists.txt e752ef1 > plugins/sipe/CMakeLists.txt PRE-CREATION > plugins/sipe/Messages.sh PRE-CREATION > plugins/sipe/ktpaccountskcm_plugin_sipe.desktop.cmake PRE-CREATION > plugins/sipe/sipe-account-ui-plugin.h PRE-CREATION > plugins/sipe/sipe-account-ui-plugin.cpp PRE-CREATION > plugins/sipe/sipe-account-ui.h PRE-CREATION > plugins/sipe/sipe-account-ui.cpp PRE-CREATION > plugins/sipe/sipe-advanced-options-widget.h PRE-CREATION > plugins/sipe/sipe-advanced-options-widget.cpp PRE-CREATION > plugins/sipe/sipe-advanced-options-widget.ui PRE-CREATION > plugins/sipe/sipe-main-options-widget.h PRE-CREATION > plugins/sipe/sipe-main-options-widget.cpp PRE-CREATION > plugins/sipe/sipe-main-options-widget.ui PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/114121/diff/ > > > Testing > ------- > > only basic testing done, not all advanced options tested > > > Thanks, > > Maksim Melnikau > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
