----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114121/#review46481 -----------------------------------------------------------
Couple comments on the UI itself File Attachment: ui - sipe_sipe.png <https://git.reviewboard.kde.org//r/114121/#fcomment127> The checkboxes should have the labels on the right side as per our HIG[1], also so it's easier to toggle the checkbox as you can also click the label [1] - http://techbase.kde.org/Projects/Usability/HIG/Check_Box (see Appearance) File Attachment: ui - sipe_sipe.png <https://git.reviewboard.kde.org//r/114121/#fcomment128> Are there known values for this? If so, we should make it a combobox; same for the auth scheme - Martin Klapetek On Dec. 31, 2013, 1:26 p.m., Maksim Melnikau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114121/ > ----------------------------------------------------------- > > (Updated Dec. 31, 2013, 1:26 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-accounts-kcm > > > Description > ------- > > telepathy-sipe e.g. pidgin-sipe telepathy's backend support > > > Diffs > ----- > > plugins/CMakeLists.txt e752ef1 > plugins/sipe/CMakeLists.txt PRE-CREATION > plugins/sipe/Messages.sh PRE-CREATION > plugins/sipe/ktpaccountskcm_plugin_sipe.desktop.cmake PRE-CREATION > plugins/sipe/sipe-account-ui-plugin.h PRE-CREATION > plugins/sipe/sipe-account-ui-plugin.cpp PRE-CREATION > plugins/sipe/sipe-account-ui.h PRE-CREATION > plugins/sipe/sipe-account-ui.cpp PRE-CREATION > plugins/sipe/sipe-advanced-options-widget.h PRE-CREATION > plugins/sipe/sipe-advanced-options-widget.cpp PRE-CREATION > plugins/sipe/sipe-advanced-options-widget.ui PRE-CREATION > plugins/sipe/sipe-main-options-widget.h PRE-CREATION > plugins/sipe/sipe-main-options-widget.cpp PRE-CREATION > plugins/sipe/sipe-main-options-widget.ui PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/114121/diff/ > > > Testing > ------- > > only basic testing done, not all advanced options tested > > > File Attachments > ---------------- > > ui > > https://git.reviewboard.kde.org/media/uploaded/files/2013/12/31/2d6fe8f2-3913-4884-8e14-e49d8f9b38e0__sipe_sipe.png > > > Thanks, > > Maksim Melnikau > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
