> On Feb. 3, 2014, 5:44 p.m., Martin Klapetek wrote: > > Thanks for the patch. > > > > I'd like to rework this a bit. If you disable it in system settings, let's > > not show it in the drop down menu in contact list at all. That will be > > tricky however as we have some hacks in there as you could see, this might > > use some rework too in fact, but let's focus on the now playing now. > > > > So - disabled in system settings - it hides from the drop down menu > > completely.
As for "we have some hacks in there", I meant that in the dropdown we check for the index being count() - 1 or -2, if the nowplaying is not present, it will break. Might be good to solve this at once so we don't have "if (current_condition || (nowplaying_disabled && count()-1)"-code. Sorry for not being clear from start, I was doing too many things at once :) - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115425/#review48836 ----------------------------------------------------------- On Feb. 3, 2014, 4 p.m., James Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115425/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2014, 4 p.m.) > > > Review request for Telepathy and Martin Klapetek. > > > Repository: ktp-contact-list > > > Description > ------- > > Enables / disables Now Playing in systemsettings every time it is enabled / > disabled in the contact list. > > Fixes systemsettings kcm showing nowplaying enabled while the contact list > has disabled its functionality. > > > Diffs > ----- > > global-presence-chooser.cpp 2047473 > > Diff: https://git.reviewboard.kde.org/r/115425/diff/ > > > Testing > ------- > > Compile, run. > > > Thanks, > > James Smith > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
