----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115425/#review49821 -----------------------------------------------------------
global-presence-chooser.cpp <https://git.reviewboard.kde.org/r/115425/#comment35018> Are you on our mailing list? We're in a string freeze so this can't go in 0.8. Why do we want want to show a prompt when you chose something else? global-presence-chooser.cpp <https://git.reviewboard.kde.org/r/115425/#comment35019> So the summary of this patch is that you're removing the activateNowPlaying signals and instead relying on changing the config and sending a configChanged method. The slots still exist in the kded so this is very half finished. It seems like all of these changes are just going round in circles changing things rather than coming up with a understanding of how things are meant to work and coming up with a solid design. Martin: now playing is your area, can you please comment. There have been several people randomly hacking on this now and things are still broken. Can you please comment and fix this mess. What is the purpose of the config and the nowPlaying signals? How is it /meant/ to work? - David Edmundson On Feb. 15, 2014, 1:25 p.m., James Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115425/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2014, 1:25 p.m.) > > > Review request for Telepathy and Martin Klapetek. > > > Repository: ktp-contact-list > > > Description > ------- > > Enables / disables Now Playing in systemsettings every time it is enabled / > disabled in the contact list. > > Fixes systemsettings kcm showing nowplaying enabled while the contact list > has disabled its functionality. > > > Diffs > ----- > > global-presence-chooser.cpp 2047473 > > Diff: https://git.reviewboard.kde.org/r/115425/diff/ > > > Testing > ------- > > Compile, run. > > > Thanks, > > James Smith > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
