----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115463/#review48895 -----------------------------------------------------------
Thanks! The patch looks good, just a few small issues. KTp/actions.cpp <https://git.reviewboard.kde.org/r/115463/#comment34520> Please remove the whitespaces (you can configure your KDevelop to do that for you when you save the document) KTp/actions.cpp <https://git.reviewboard.kde.org/r/115463/#comment34521> Please fix the indentation - it looks like 2 tabs? Should be 4 spaces. Again you can configure it in KDevelop. KTp/actions.cpp <https://git.reviewboard.kde.org/r/115463/#comment34522> Replace the tab between ")" and "{" by single space KTp/actions.cpp <https://git.reviewboard.kde.org/r/115463/#comment34524> I think you need to call the specific constructor overload that takes 3 arguments: suggested filename, content type and file size. You should be able to get content type and size from the QFileInfo above. - Dan Vrátil On Feb. 4, 2014, 1:01 p.m., Jan Stourac wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115463/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2014, 1:01 p.m.) > > > Review request for Telepathy. > > > Bugs: 326786 > http://bugs.kde.org/show_bug.cgi?id=326786 > > > Repository: ktp-common-internals > > > Description > ------- > > each file transfer is checked for using google talk and forbidden > extensions...in that case, "_" character is appended to suggested file name. > for all other cases, transfer process remains the same. > > > Diffs > ----- > > KTp/actions.cpp ec8a19e > > Diff: https://git.reviewboard.kde.org/r/115463/diff/ > > > Testing > ------- > > > Thanks, > > Jan Stourac > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
