-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115463/
-----------------------------------------------------------
(Updated Feb. 5, 2014, 12:43 p.m.)
Review request for Telepathy.
Changes
-------
Sender is notified when transferred file ends with .ini_ or .exe_, that the
rename is because of google limitations. Notification can be configured in
KTelepathy in the same way as others (settings dialog).
To resolve:
- text of notification
- icon of notification (maybe warn sign)
- translations
- show only for google talk service (i was unable to find out the right method
which provides this information)
Bugs: 326786
http://bugs.kde.org/show_bug.cgi?id=326786
Repository: ktp-common-internals
Description
-------
each file transfer is checked for using google talk and forbidden
extensions...in that case, "_" character is appended to suggested file name.
for all other cases, transfer process remains the same.
Diffs
-----
KTp/actions.cpp ec8a19e
Diff: https://git.reviewboard.kde.org/r/115463/diff/
Testing
-------
File Attachments (updated)
----------------
KNotification event description
https://git.reviewboard.kde.org/media/uploaded/files/2014/02/05/d4fb6075-e410-4dcc-9d3f-96dc258c6299__326786_knotify.patch
Outgoing file transfer handler
https://git.reviewboard.kde.org/media/uploaded/files/2014/02/05/5d72503a-4416-4651-ab79-f9ea5983590e__326786_ft-handler.patch
Thanks,
Jan Stourac
_______________________________________________
KDE-Telepathy mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-telepathy
