> On Feb. 5, 2014, 5:33 p.m., Martin Klapetek wrote:
> > data/ktelepathy.notifyrc, line 1810
> > <https://git.reviewboard.kde.org/r/115463/diff/5/?file=242101#file242101line1810>
> >
> >     The wording should imho be "Sending exe or ini...", simillarily the 
> > comment should explain the user what this notification is for, so I'd 
> > suggest something like "Informs that the file sent was renamed because 
> > GoogleTalk (should be just Google? Gmail is blocked too) blocks some 
> > extensions"

suggestions:

Configuration dialog - title: GoogleTalk file renamed
Configuration dialog - description: An outgoing file with forbidden extension 
.exe or .ini has been renamed.
Notification - title: Attention: Transferred file renamed
Notification - message: Transferring files with .exe or .ini extension is not 
allowed by GoogleTalk. Your file was renamed to <i>%1</i>.

and i prefer to keep GoogleTalk, because i think that "Gmail chat" == 
GoogleTalk and limitations of Gmail email are not our bussiness?


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115463/#review49050
-----------------------------------------------------------


On Feb. 5, 2014, 5:29 p.m., Jan Stourac wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115463/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2014, 5:29 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 326786
>     http://bugs.kde.org/show_bug.cgi?id=326786
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> each file transfer is checked for using google talk and forbidden 
> extensions...in that case, "_" character is appended to suggested file name. 
> for all other cases, transfer process remains the same.
> 
> 
> Diffs
> -----
> 
>   KTp/actions.cpp ec8a19e 
>   data/ktelepathy.notifyrc 1d2411d 
> 
> Diff: https://git.reviewboard.kde.org/r/115463/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Stourac
> 
>

_______________________________________________
KDE-Telepathy mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-telepathy

Reply via email to