> On Feb. 5, 2014, 2:24 p.m., Dan Vrátil wrote: > > data/ktelepathy.notifyrc, line 1809 > > <https://git.reviewboard.kde.org/r/115463/diff/3/?file=242000#file242000line1809> > > > > This does not seem the right place. Also I can't see anywhere in the > > code above how you raise the notification. > > > > You can check how to use KNotification in > > src/filetransferchannelapprover.cpp in ktp-approver repository for instance. > > Jan Stourac wrote: > code for raising notification is in second patch (added as extra file, > because it is from ktp-filetransfer-handler project and I can't create git > diff for both projects to one file)... > > also the event used in filetransferchannelapprover is defined in > kdetelepathy.notifyrc (wihout this definition I was not able to raise any > notification), so I don't know where else should I put it? > > David Edmundson wrote: > I'm confused. Why is it in another project?
yesterday, Dan told me on IRC to put it to filetransfer-handler, because not all possible ways how to send file in ktp use methods from actions.cpp, so in filetransfer-handler we are sure that all outgoing transfers will be checked for extension and notification will be raised...but maybe I misunderstood his idea... - Jan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115463/#review49022 ----------------------------------------------------------- On Feb. 5, 2014, 2:14 p.m., Jan Stourac wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115463/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2014, 2:14 p.m.) > > > Review request for Telepathy. > > > Bugs: 326786 > http://bugs.kde.org/show_bug.cgi?id=326786 > > > Repository: ktp-common-internals > > > Description > ------- > > each file transfer is checked for using google talk and forbidden > extensions...in that case, "_" character is appended to suggested file name. > for all other cases, transfer process remains the same. > > > Diffs > ----- > > KTp/actions.cpp ec8a19e > data/ktelepathy.notifyrc 1d2411d > > Diff: https://git.reviewboard.kde.org/r/115463/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Outgoing file transfer handler > > https://git.reviewboard.kde.org/media/uploaded/files/2014/02/05/5d72503a-4416-4651-ab79-f9ea5983590e__326786_ft-handler.patch > > > Thanks, > > Jan Stourac > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
