----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116748/#review52757 -----------------------------------------------------------
global-presence-chooser.cpp <https://git.reviewboard.kde.org/r/116748/#comment37201> So we clear out the presence just before we activate now playing. I can see two main problems: 1) the kded won't be able to restore the statusMessage when you deactivate 2) you're now in a race between us messaging the kded to start the now playing, and us telling each CM to change state and the kded monitoring that. I can only imagine this making things even messier as we'll end up going contact list -> kded: activateNowPlaying kded -> CM: setStatusMessageTo("Now Listening to...") contact list -> CM: setStatusMessage("") CM -> KDED: I've changed presenceMessage! I think if KDED is working as designed it would then disable the nowPlaying.. Either way: we're in a set of races trying to set the message to multiple things at once. - David Edmundson On March 12, 2014, 6:50 a.m., James Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116748/ > ----------------------------------------------------------- > > (Updated March 12, 2014, 6:50 a.m.) > > > Review request for Telepathy. > > > Repository: ktp-contact-list > > > Description > ------- > > Fixes a state affinity issue where the contact list won't recognise a > nowplaying plugin enable event when there is a custom status message set. > > > Diffs > ----- > > global-presence-chooser.cpp 2047473 > > Diff: https://git.reviewboard.kde.org/r/116748/diff/ > > > Testing > ------- > > Compile, run-check. > > > Thanks, > > James Smith > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
