> On March 12, 2014, 2:16 p.m., David Edmundson wrote: > > "Fixes a state affinity issue where the contact list won't recognise a > > nowplaying plugin enable event when there is a custom status message set." > > > > Can you explain why it won't be recognised? It will help me understand this > > patch. > > James Smith wrote: > The current ordering of presences (as many as I can remember) in the kded > plugin is as follows: > > b) plugin presences (w/ attached status messages) > c) user-set presences > > b) plugin presences (w/ attached status messages) > d) custom status message plugins > > c) user-set presences > d) custom status message plugins > > a) plugin presences > c) user-set presences > > d) custom status message plugins > a) plugin presences
Then should the fix not be in this kded ordering? - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116748/#review52758 ----------------------------------------------------------- On March 13, 2014, 4:29 a.m., James Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116748/ > ----------------------------------------------------------- > > (Updated March 13, 2014, 4:29 a.m.) > > > Review request for Telepathy. > > > Bugs: 332082 > http://bugs.kde.org/show_bug.cgi?id=332082 > > > Repository: ktp-contact-list > > > Description > ------- > > Fixes a state affinity issue where the contact list won't recognise a > nowplaying plugin enable event when there is a custom status message set. > > > Diffs > ----- > > global-presence-chooser.cpp 2047473 > > Diff: https://git.reviewboard.kde.org/r/116748/diff/ > > > Testing > ------- > > Compile, run-check. > > > Thanks, > > James Smith > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
