----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117556/#review55676 -----------------------------------------------------------
lib/chat-widget.cpp <https://git.reviewboard.kde.org/r/117556/#comment38755> .startsWith() is faster lib/chat-widget.cpp <https://git.reviewboard.kde.org/r/117556/#comment38756> qMin() then remove the #include <algorithm> lib/chat-widget.cpp <https://git.reviewboard.kde.org/r/117556/#comment38758> maybe you can document this with some examples lib/chat-widget.cpp <https://git.reviewboard.kde.org/r/117556/#comment38757> QLatin1Char(' ') for all single characters. Qt will go through a faster path for finding/adding one letter rather than many. lib/chat-widget.cpp <https://git.reviewboard.kde.org/r/117556/#comment38759> i18n lib/chat-widget.cpp <https://git.reviewboard.kde.org/r/117556/#comment38760> TpQt lib/chat-widget.cpp <https://git.reviewboard.kde.org/r/117556/#comment38761> Don't we need this code inside onParticipantsChanged()? Otherwise we'll change if someone joins woshibon lib/chat-widget.cpp <https://git.reviewboard.kde.org/r/117556/#comment38754> i18n - David Edmundson On April 14, 2014, 12:08 a.m., Daniel Cohen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117556/ > ----------------------------------------------------------- > > (Updated April 14, 2014, 12:08 a.m.) > > > Review request for Telepathy. > > > Repository: ktp-text-ui > > > Description > ------- > > When creating a group chat room via 'invite to chat', the tab name is now set > to the participants names. > > A maximum of two names are displayed, with the rest counted in the format > being 'Bob, Fred, +2'. > The names displayed are filtered by trying to take the first part of the user > alias, > e.g. 'fred' from [email protected], or 'Bob' from 'Bob Foreman'. > > > Diffs > ----- > > lib/chat-widget.h d9c4e60 > lib/chat-widget.cpp 3682742 > > Diff: https://git.reviewboard.kde.org/r/117556/diff/ > > > Testing > ------- > > joining and leaving an ad-hoc group chat room with multiple accounts. > > > Thanks, > > Daniel Cohen > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
