> On April 14, 2014, 12:41 a.m., David Edmundson wrote: > > lib/chat-widget.cpp, line 1062 > > <https://git.reviewboard.kde.org/r/117556/diff/1/?file=265401#file265401line1062> > > > > Don't we need this code inside onParticipantsChanged()? > > > > Otherwise we'll change if someone joins woshibon
onParticipantsChanged() isn't called until the first contact joins, not including oneself, so I thought that this would be more efficient than calling the whole function just for labelling the tab temporarily till the first person joins. - Daniel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117556/#review55676 ----------------------------------------------------------- On April 14, 2014, 11:39 a.m., Daniel Cohen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117556/ > ----------------------------------------------------------- > > (Updated April 14, 2014, 11:39 a.m.) > > > Review request for Telepathy. > > > Repository: ktp-text-ui > > > Description > ------- > > When creating a group chat room via 'invite to chat', the tab name is now set > to the participants names. > > A maximum of two names are displayed, with the rest counted in the format > being 'Bob, Fred, +2'. > The names displayed are filtered by trying to take the first part of the user > alias, > e.g. 'fred' from [email protected], or 'Bob' from 'Bob Foreman'. > > > Diffs > ----- > > lib/chat-widget.h d9c4e60 > lib/chat-widget.cpp 3682742 > > Diff: https://git.reviewboard.kde.org/r/117556/diff/ > > > Testing > ------- > > joining and leaving an ad-hoc group chat room with multiple accounts. > > > Thanks, > > Daniel Cohen > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
