> On April 14, 2014, 11:39 p.m., Daniele E. Domenichelli wrote: > > lib/chat-widget.h, line 151 > > <https://git.reviewboard.kde.org/r/117570/diff/1/?file=266039#file266039line151> > > > > Since you are changing this, perhaps you could make it with the same > > signature as Tp::Channel::groupMembersChanged > > http://telepathy.freedesktop.org/doc/telepathy-qt/a00106.html#a9a19634088f78c3fb81fd166df72739e > > , it will be easier in the future if we want to support the > > part/quit/kick/ban messages. (Also perhaps using > > groupLocalPendingMembersAdded and groupRemotePendingMembersAdded it could > > be possible to show contacts invited that did not accept the invitation > > yet? Anyway that's for some future patch) > > David Edmundson wrote: > From what I could tell group*PendingMembersAdded was never called. I was > trying to solve exactly what you just suggested :)
Perhaps gabble or tp-qt bindings are broken ;) - Daniele E. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117570/#review55783 ----------------------------------------------------------- On April 14, 2014, 8:02 p.m., Daniel Cohen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117570/ > ----------------------------------------------------------- > > (Updated April 14, 2014, 8:02 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-text-ui > > > Description > ------- > > Added join message capability. Configuration of displaying it is tied in with > the option for showing people leaving. > > > Diffs > ----- > > config/appearance-config-tab.h 9582660 > config/appearance-config-tab.cpp f8314d8 > config/appearance-config.ui 6440cba > lib/adium-theme-view.h 5eaab55 > lib/adium-theme-view.cpp e0ad0b1 > lib/chat-widget.h 5428104 > lib/chat-widget.cpp 3929e45 > > Diff: https://git.reviewboard.kde.org/r/117570/diff/ > > > Testing > ------- > > Joined and left with several accounts into a chat room. > > > Thanks, > > Daniel Cohen > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
