> On April 14, 2014, 11:39 p.m., Daniele E. Domenichelli wrote: > > config/appearance-config.ui, line 142 > > <https://git.reviewboard.kde.org/r/117570/diff/1/?file=266036#file266036line142> > > > > Perhaps it should be join/part? If you change this perhaps also the > > names of the methods/variables should be updated
IMHO 'part' is less clear than 'leave' as it's traditionally an IRC term, where as 'leave' is a more generally understood term - happy to hear other people chime in on the opposite though. > On April 14, 2014, 11:39 p.m., Daniele E. Domenichelli wrote: > > config/appearance-config-tab.cpp, lines 210-216 > > <https://git.reviewboard.kde.org/r/117570/diff/1/?file=266035#file266035line210> > > > > Perhaps it is a stupid comment, but the order of the events does not > > make sense. > > > > I'd put the "leave" event after this one as an history event > > (AdiumThemeStatusInfo(false), no changes needed), followed by this "join" > > event as not-history (AdiumThemeStatusInfo(false)) I'm not sure I understand this - surely the join event will always happen before the leave event? (Is the first AdiumThemeStatusInfo(false) a typo, and it should be true?) - Daniel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117570/#review55783 ----------------------------------------------------------- On April 14, 2014, 8:02 p.m., Daniel Cohen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117570/ > ----------------------------------------------------------- > > (Updated April 14, 2014, 8:02 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-text-ui > > > Description > ------- > > Added join message capability. Configuration of displaying it is tied in with > the option for showing people leaving. > > > Diffs > ----- > > config/appearance-config-tab.h 9582660 > config/appearance-config-tab.cpp f8314d8 > config/appearance-config.ui 6440cba > lib/adium-theme-view.h 5eaab55 > lib/adium-theme-view.cpp e0ad0b1 > lib/chat-widget.h 5428104 > lib/chat-widget.cpp 3929e45 > > Diff: https://git.reviewboard.kde.org/r/117570/diff/ > > > Testing > ------- > > Joined and left with several accounts into a chat room. > > > Thanks, > > Daniel Cohen > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
