----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117916/#review57030 -----------------------------------------------------------
As you know from bugzilla, this was slihghtly controversial. There's some good args for and against. I'm going to try it for a bit and report back and some real world usage. - David Edmundson On April 30, 2014, 9:09 p.m., Renato Atilio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117916/ > ----------------------------------------------------------- > > (Updated April 30, 2014, 9:09 p.m.) > > > Review request for Telepathy. > > > Bugs: 318591 > http://bugs.kde.org/show_bug.cgi?id=318591 > > > Repository: ktp-contact-list > > > Description > ------- > > Replace a void action (typing does absolutely nothing currently) by the > contact filtering when typing. > > What this diff does: > 1. Focus the contacts list tree view instead of the status combo box on the > contact list opening > 2. When searching, focus the contacts list and select the index from > keyboardSerch() if valid or first index otherwise - so the user can just type > Enter after searching, if needed, to open the chat window > 3. When typing on the contacts list, it captures the key events and sends > them to the filter bar so it can determine if the event is a text insertion, > a backspace or a close request > 4. Set the focus on the contacts list after a close request > > > Diffs > ----- > > contact-list-widget.h 9aa3a48 > contact-list-widget.cpp 49d21ee > filter-bar.h 76dc572 > filter-bar.cpp dd57421 > main-widget.h aa69daa > main-widget.cpp 27a941d > > Diff: https://git.reviewboard.kde.org/r/117916/diff/ > > > Testing > ------- > > > Thanks, > > Renato Atilio > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
