> On Aug. 7, 2014, 2:24 p.m., Martin Klapetek wrote: > > kpeople/CMakeLists.txt, lines 3-4 > > <https://git.reviewboard.kde.org/r/119636/diff/2/?file=300616#file300616line3> > > > > Now that I'm looking at this - the chat plugin should be part of the > > uiplugins/ folder as that's what it is, so let's move it there, you can > > then just directly copy-paste/append the chatplugin/CMakeLists.txt into > > uiplugins/CMakeLists.txt
Instead of appending the CMakeList.txt we could move this line "add_subdirectory(chatplugin)" to chatplugin/CMakeLists.txt - Nilesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119636/#review63964 ----------------------------------------------------------- On Aug. 6, 2014, 10:18 p.m., Nilesh Suthar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119636/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2014, 10:18 p.m.) > > > Review request for Telepathy and Martin Klapetek. > > > Repository: ktp-common-internals > > > Description > ------- > > Added Chat Plugin for KPeople > > > Diffs > ----- > > kpeople/CMakeLists.txt c5f1019 > kpeople/chatplugin/CMakeLists.txt PRE-CREATION > kpeople/chatplugin/chatlistviewdelegate.h PRE-CREATION > kpeople/chatplugin/chatlistviewdelegate.cpp PRE-CREATION > kpeople/chatplugin/kpeople_chat_plugin.cpp PRE-CREATION > kpeople/chatplugin/kpeople_chat_plugin.desktop PRE-CREATION > kpeople/chatplugin/kpeople_chat_plugin.h PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119636/diff/ > > > Testing > ------- > > Both Building fine KPeople and KCI > > > Thanks, > > Nilesh Suthar > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
