----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119636/#review63972 -----------------------------------------------------------
kpeople/uiplugins/chatplugin/chatlistviewdelegate.h <https://git.reviewboard.kde.org/r/119636/#comment44647> type names usually use CamelCase kpeople/uiplugins/chatplugin/chatlistviewdelegate.h <https://git.reviewboard.kde.org/r/119636/#comment44648> enum values usually use CamelCase too kpeople/uiplugins/chatplugin/kpeople_chat_plugin.cpp <https://git.reviewboard.kde.org/r/119636/#comment44652> You can just do KTp::LogEntity logEntity(Tp::HandleTypeContact, ....); kpeople/uiplugins/chatplugin/kpeople_chat_plugin.cpp <https://git.reviewboard.kde.org/r/119636/#comment44653> logManager->queryDates() will always return a non-null pointer, so the check is not needed. Also connect() can handle null pointers kpeople/uiplugins/chatplugin/kpeople_chat_plugin.cpp <https://git.reviewboard.kde.org/r/119636/#comment44651> Does not seem to be used anywhere? kpeople/uiplugins/chatplugin/kpeople_chat_plugin.cpp <https://git.reviewboard.kde.org/r/119636/#comment44649> Better to compare with an actual value, otherwise it's not very clear in this case which case is being handled kpeople/uiplugins/chatplugin/kpeople_chat_plugin.cpp <https://git.reviewboard.kde.org/r/119636/#comment44650> Might be wort listing a date (at least in case the message is not from today), since the last chat log can be a day old or a year old. - Dan Vrátil On Aug. 7, 2014, 11:42 a.m., Nilesh Suthar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119636/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2014, 11:42 a.m.) > > > Review request for Telepathy and Martin Klapetek. > > > Repository: ktp-common-internals > > > Description > ------- > > Added Chat Plugin for KPeople > > > Diffs > ----- > > kpeople/CMakeLists.txt c5f1019 > kpeople/uiplugins/CMakeLists.txt 2fa6b8b > kpeople/uiplugins/chatplugin/CMakeLists.txt PRE-CREATION > kpeople/uiplugins/chatplugin/chatlistviewdelegate.h PRE-CREATION > kpeople/uiplugins/chatplugin/chatlistviewdelegate.cpp PRE-CREATION > kpeople/uiplugins/chatplugin/kpeople_chat_plugin.h PRE-CREATION > kpeople/uiplugins/chatplugin/kpeople_chat_plugin.cpp PRE-CREATION > kpeople/uiplugins/chatplugin/kpeople_chat_plugin.desktop PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119636/diff/ > > > Testing > ------- > > Both Building fine KPeople and KCI > > > Thanks, > > Nilesh Suthar > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
