----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119845/#review64960 -----------------------------------------------------------
src/call-window.cpp <https://git.reviewboard.kde.org/r/119845/#comment45397> This block is confusing, it should either be if () { } else if () { } else {} OR if () { } if () { } else {} Someone should also investigate why showing dtmf in fullscreen is not working; switching off fullscreen just to show dtmf is not the best - Martin Klapetek On Aug. 20, 2014, 10:07 p.m., Ovidiu-Florin Bogdan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119845/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2014, 10:07 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-call-ui > > > Description > ------- > > Fix for https://git.reviewboard.kde.org/r/119467/#comment44421 > > > Diffs > ----- > > src/call-window.h 492f7d6 > src/call-window.cpp ae0bbdb > > Diff: https://git.reviewboard.kde.org/r/119845/diff/ > > > Testing > ------- > > Compiled. > > > Thanks, > > Ovidiu-Florin Bogdan > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
