> On Aug. 20, 2014, 8:17 p.m., Diane Trout wrote: > > src/call-window.cpp, line 633 > > <https://git.reviewboard.kde.org/r/119845/diff/2/?file=306750#file306750line633> > > > > Should toggleFullScreen just call exitFullScreen instead of duplicating > > the code? > > > > And then maybe the else block should be in a enterFullScreen function. > > Martin Klapetek wrote: > Yes. > > Martin Klapetek wrote: > Well actually I think the "exitFullScreen" is not needed? The "exit full > screen" button can be connected just to the "toggleFullScreen", because that > checks if it is full screen or not, so will do the right thing(tm)...
Even in this state, I've tested and I couldn't exit the fullScreen by using ESC. In fact I couldn't exit fullScreen by any means, except by ending the call. I was hoping for some feedback on how to make this work. - Ovidiu-Florin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119845/#review64936 ----------------------------------------------------------- On Aug. 20, 2014, 8:07 p.m., Ovidiu-Florin Bogdan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119845/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2014, 8:07 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-call-ui > > > Description > ------- > > Fix for https://git.reviewboard.kde.org/r/119467/#comment44421 > > > Diffs > ----- > > src/call-window.h 492f7d6 > src/call-window.cpp ae0bbdb > > Diff: https://git.reviewboard.kde.org/r/119845/diff/ > > > Testing > ------- > > Compiled. > > > Thanks, > > Ovidiu-Florin Bogdan > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
