> On Aug. 27, 2014, 4:39 p.m., David Edmundson wrote: > > sasl-auth-op.cpp, line 80 > > <https://git.reviewboard.kde.org/r/119955/diff/1/?file=307835#file307835line80> > > > > here we check m_accountStorageId is valid, and maps Tp accounts to SSO. > > > > I don't see why your new code has a config file, and if it is needed > > then this code here is super wrong. > > Martin Klapetek wrote: > Well I asked a while ago if there's a way to store the accounts id with > the tp accounts, got no real answer so I went for a simple intermediate > solution with using a config file so I can have it working. > > I'll investigate how it used to use this in the kde4 version.
Ok here's my findings: * the previous implementation relied on the mission control patch that is used by ubuntu, basically it moved what I did with the config file into MC directly, I'm not in favor of depending on that * we need both ways mapping - for example when the kaccount is removed, we have only its id, so we need kaccounts-id<-->tp-id map somewhere; my config file handles this * I'll port the existing stuff away from the AccountStorageInterface - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119955/#review65372 ----------------------------------------------------------- On Aug. 27, 2014, 4:09 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119955/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2014, 4:09 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-auth-handler > > > Description > ------- > > This makes auth handler look into the SSO storage for credentials. If the > password is wrong, the user is prompted for new one and if he wants to save > that password, the password is overriden in SSO. > > > Diffs > ----- > > sasl-auth-op.cpp c54d662 > x-telepathy-password-auth-operation.cpp f999748 > x-telepathy-password-auth-operation.h 65d6462 > x-telepathy-password-prompt.h fa8c1ce > x-telepathy-password-prompt.cpp b53b1f5 > > Diff: https://git.reviewboard.kde.org/r/119955/diff/ > > > Testing > ------- > > I created an account using KAccounts with both good and wrong password. With > good password it just authenticates as expected, with wrong password I get a > password prompt, entering a correct password makes it override the stored one > and any further login does not spawn the password prompt again. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
