> On Sept. 15, 2014, 11:25 a.m., Martin Klapetek wrote: > > Pingpingping > > David Edmundson wrote: > after 0.9 > > Martin Klapetek wrote: > It's frameworks branch anyway... > > Martin Klapetek wrote: > Now that 0.9 is out, this could now use some review ;)
As the other ports are starting to appear, I'm going to ship this on Monday. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119955/#review66532 ----------------------------------------------------------- On Oct. 9, 2014, 11:20 a.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119955/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2014, 11:20 a.m.) > > > Review request for Telepathy. > > > Repository: ktp-auth-handler > > > Description > ------- > > This makes auth handler look into the SSO storage for credentials. If the > password is wrong, the user is prompted for new one and if he wants to save > that password, the password is overriden in SSO. > > > Diffs > ----- > > CMakeLists.txt 5994416 > cmake/modules/FindKAccounts.cmake PRE-CREATION > getcredentialsjob.h 0981115 > getcredentialsjob.cpp 7016ede > sasl-auth-op.h 9808019 > sasl-auth-op.cpp c54d662 > x-telepathy-password-auth-operation.h 65d6462 > x-telepathy-password-auth-operation.cpp f999748 > x-telepathy-password-prompt.h fa8c1ce > x-telepathy-password-prompt.cpp b53b1f5 > x-telepathy-sso-facebook-operation.h 921ef2a > x-telepathy-sso-facebook-operation.cpp a4a9dc9 > x-telepathy-sso-google-operation.h 1fa4c3d > x-telepathy-sso-google-operation.cpp f678916 > > Diff: https://git.reviewboard.kde.org/r/119955/diff/ > > > Testing > ------- > > I created an account using KAccounts with both good and wrong password. With > good password it just authenticates as expected, with wrong password I get a > password prompt, entering a correct password makes it override the stored one > and any further login does not spawn the password prompt again. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
