----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119963/ -----------------------------------------------------------
(Updated Aug. 30, 2014, 9:36 p.m.) Review request for Telepathy. Changes ------- Follow Martin's suggestion and make extra sure the full screeen checkbox is set correctly. Also I occasionally got a notification that the window was hidden when leaving full screen mode. I think its because CallWindow::hideEvent is checking the state of the CallWindow. However the CallWindow is being hidden, and its the qmlUi that's having its full screen / widget state changed. I didn't add it to this patch because it seemed like a different change... Repository: ktp-call-ui Description ------- Toggling the full screen via the menu and then escape previously left the state as checked Diffs (updated) ----- src/call-window.cpp 2cbbb7be5cf59a8ad06e11dc2d549b3353fd48f4 Diff: https://git.reviewboard.kde.org/r/119963/diff/ Testing ------- Also I discovered there's a KToggleFullScreenAction which I tried to use, but that seems to want to maximize a traditional qt widget and the qmlUi widget didn't maximize/minimize properly. The advantage to the FullScreenAction is it properly sets the icon and description without having to code it. If anyone has a suggestion on how to get KToggleFUllScreenAction to work with the qmlUi widget that would probably be better than this. (Oh and I tested by calling myself and toggling the full screen and making sure the check box was off after I hit escape) Thanks, Diane Trout
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
