----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119963/#review65650 -----------------------------------------------------------
Ship it! Ship It! - Martin Klapetek On Aug. 31, 2014, 6:36 a.m., Diane Trout wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119963/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2014, 6:36 a.m.) > > > Review request for Telepathy. > > > Repository: ktp-call-ui > > > Description > ------- > > Toggling the full screen via the menu and then escape previously left the > state as checked > > > Diffs > ----- > > src/call-window.cpp 2cbbb7be5cf59a8ad06e11dc2d549b3353fd48f4 > > Diff: https://git.reviewboard.kde.org/r/119963/diff/ > > > Testing > ------- > > Also I discovered there's a KToggleFullScreenAction which I tried to use, but > that seems to want to maximize a traditional qt widget and the qmlUi widget > didn't maximize/minimize properly. > > The advantage to the FullScreenAction is it properly sets the icon and > description without having to code it. If anyone has a suggestion on how to > get KToggleFUllScreenAction to work with the qmlUi widget that would probably > be better than this. > > (Oh and I tested by calling myself and toggling the full screen and making > sure the check box was off after I hit escape) > > > Thanks, > > Diane Trout > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
