> On oct. 9, 2014, 4:35 p.m., Àlex Fiestas wrote: > > I would like to see this new code tested either by unit tests (preferred) > > or integration test.
Also think that lambdas might make the code look cool but they usually produce coupling are are really hard to test, so be careful. - Àlex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120521/#review68176 ----------------------------------------------------------- On oct. 7, 2014, 2:49 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120521/ > ----------------------------------------------------------- > > (Updated oct. 7, 2014, 2:49 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-common-internals > > > Description > ------- > > This finishes the KAccounts plugin for KTp. Telepathy accounts are now > created/removed for all KAccounts accounts which provide the IM service (till > now it was only direct KTp accounts). Furthermore this makes > enabling/disabling accounts from KAccounts work too. > > > Diffs > ----- > > kaccounts/CMakeLists.txt 7305d81 > kaccounts/kaccounts-ktp-plugin.h 92cbc18 > kaccounts/kaccounts-ktp-plugin.cpp f9b722c > > Diff: https://git.reviewboard.kde.org/r/120521/diff/ > > > Testing > ------- > > Created couple accounts, enabled and disabled them, removed them again in the > end and cross-checked each operation with contact list & mc-tool. All is good. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
