> On Oct. 29, 2014, 5:16 p.m., Aleix Pol Gonzalez wrote: > > kaccounts/kaccounts-ktp-plugin.cpp, line 201 > > <https://git.reviewboard.kde.org/r/120521/diff/2/?file=322490#file322490line201> > > > > This looks too big chunk of code to be in a lambda...
Why? It just checks the result op and then stores a config...I've seen much bigger lambdas ;) - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120521/#review69465 ----------------------------------------------------------- On Oct. 28, 2014, 4:29 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120521/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2014, 4:29 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-common-internals > > > Description > ------- > > This finishes the KAccounts plugin for KTp. Telepathy accounts are now > created/removed for all KAccounts accounts which provide the IM service (till > now it was only direct KTp accounts). Furthermore this makes > enabling/disabling accounts from KAccounts work too. > > > Diffs > ----- > > kaccounts/CMakeLists.txt 3b86540 > kaccounts/kaccounts-ktp-plugin.h 92cbc18 > kaccounts/kaccounts-ktp-plugin.cpp f9b722c > > Diff: https://git.reviewboard.kde.org/r/120521/diff/ > > > Testing > ------- > > Created couple accounts, enabled and disabled them, removed them again in the > end and cross-checked each operation with contact list & mc-tool. All is good. > > > Thanks, > > Martin Klapetek > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
