> On Oct. 27, 2014, 1:43 a.m., Aleix Pol Gonzalez wrote: > > src/telepathy-base-job.cpp, line 139 > > <https://git.reviewboard.kde.org/r/120804/diff/1/?file=322076#file322076line139> > > > > That change shouldn't be needed...?
Yep, in fact you shouldn't need to include .moc files unless there is a Q_OBJECT class declared in the .cpp. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120804/#review69182 ----------------------------------------------------------- On Oct. 26, 2014, 2:26 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120804/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2014, 2:26 a.m.) > > > Review request for Telepathy. > > > Repository: ktp-filetransfer-handler > > > Description > ------- > > Initial port to KF5 > > > Diffs > ----- > > CMakeLists.txt 5664e52 > src/CMakeLists.txt ebd892c > src/handle-incoming-file-transfer-channel-job.cpp 36b8310 > src/handle-outgoing-file-transfer-channel-job.cpp 762bd12 > src/main.cpp 5382122 > src/telepathy-base-job.cpp 3dab71e > > Diff: https://git.reviewboard.kde.org/r/120804/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
