> On Oct. 27, 2014, 7:22 a.m., Martin Klapetek wrote: > > src/main.cpp, lines 59-60 > > <https://git.reviewboard.kde.org/r/120804/diff/1/?file=322075#file322075line59> > > > > KTp::TelepathyHandlerApplication contains QCommandLineParser, the call > > above should probably just be removed
TelepathyHandlerApplication now inherits QApplication so it is needed - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120804/#review69185 ----------------------------------------------------------- On Oct. 28, 2014, 12:57 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120804/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2014, 12:57 p.m.) > > > Review request for Telepathy. > > > Repository: ktp-filetransfer-handler > > > Description > ------- > > Initial port to KF5 > > > Diffs > ----- > > src/CMakeLists.txt ebd892c > src/handle-incoming-file-transfer-channel-job.cpp 36b8310 > src/handle-outgoing-file-transfer-channel-job.cpp 762bd12 > src/main.cpp 5382122 > src/telepathy-base-job.cpp 3dab71e > CMakeLists.txt 5664e52 > cmake/modules/COPYING-CMAKE-SCRIPTS 4b41776 > cmake/modules/FindKTp.cmake 8facd12 > > Diff: https://git.reviewboard.kde.org/r/120804/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
