----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121544/#review72106 -----------------------------------------------------------
Ship it! cmake/modules/TelepathyDefaults.cmake <https://git.reviewboard.kde.org/r/121544/#comment50276> FORCE shouldn't be needed. Looks good to me. - Aleix Pol Gonzalez On Dec. 15, 2014, 11:30 p.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121544/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2014, 11:30 p.m.) > > > Review request for Telepathy and Aleix Pol Gonzalez. > > > Repository: telepathy-logger-qt > > > Description > ------- > > this is less fragile in abs. vs. relative paths, etc.. > > > Diffs > ----- > > CMakeLists.txt 0022600 > TelepathyLoggerQt/CMakeLists.txt 125b56b > TelepathyLoggerQt/TelepathyLoggerQt.pc.in 508fe25 > TelepathyLoggerQt/TelepathyLoggerQtConfig.cmake.in 0a4eef9 > cmake/modules/TelepathyDefaults.cmake ec091e2 > > Diff: https://git.reviewboard.kde.org/r/121544/diff/ > > > Testing > ------- > > so far tried only cmake sets correct vars... > > > Thanks, > > Hrvoje Senjan > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
