----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121544/#review72122 -----------------------------------------------------------
cmake/modules/TelepathyDefaults.cmake <https://git.reviewboard.kde.org/r/121544/#comment50303> You should not offer these ``XXX_DESTINATION`` variables to the user. ``CMAKE_INSTALL_XXXDIR`` are already cached, modifying these variables will modify the ``DESTINATION`` ones too. In this way you will just get extra cmake cached variables in GUIs, and you won't be able to modify them, since they are forced every time. You can either make them ``INTERNAL`` instead of ``PATH`` (``FORCE`` is implied in this case), or you can just set them as normal variables since you are including the file in the main ``CMakeLists.txt`` (therefore you don't have problems with variable scope), and since it does not make much sense to cache them. Also I think I remember that there is some reason to use the **relative** path instead of **absolute** when doing ``install()`` (therefore ``CMAKE_INSTALL_XXXDIR`` instead of ``CMAKE_INSTALL_FULL_XXXDIR``), but I might be wrong here... - Daniele E. Domenichelli On Dec. 15, 2014, 11:30 p.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121544/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2014, 11:30 p.m.) > > > Review request for Telepathy and Aleix Pol Gonzalez. > > > Repository: telepathy-logger-qt > > > Description > ------- > > this is less fragile in abs. vs. relative paths, etc.. > > > Diffs > ----- > > CMakeLists.txt 0022600 > TelepathyLoggerQt/CMakeLists.txt 125b56b > TelepathyLoggerQt/TelepathyLoggerQt.pc.in 508fe25 > TelepathyLoggerQt/TelepathyLoggerQtConfig.cmake.in 0a4eef9 > cmake/modules/TelepathyDefaults.cmake ec091e2 > > Diff: https://git.reviewboard.kde.org/r/121544/diff/ > > > Testing > ------- > > so far tried only cmake sets correct vars... > > > Thanks, > > Hrvoje Senjan > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
