----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126510/#review93145 -----------------------------------------------------------
seems good account-status-helper.cpp (line 44) <https://git.reviewboard.kde.org/r/126510/#comment63510> leaks account-status-helper.cpp (line 46) <https://git.reviewboard.kde.org/r/126510/#comment63511> you need to wait for the consumer to load otherwise you get an empty (or "00000-0000-0000") string here account-status-helper.cpp (line 262) <https://git.reviewboard.kde.org/r/126510/#comment63512> else if KTp::Presence(m_requestedGlobalPresence).isValid() ? - David Edmundson On Feb. 22, 2016, 9:30 a.m., James Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126510/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2016, 9:30 a.m.) > > > Review request for Telepathy. > > > Bugs: 284517 > http://bugs.kde.org/show_bug.cgi?id=284517 > > > Repository: ktp-kded-module > > > Description > ------- > > New features: > -Saves per-activity account presences between activities. > > > Diffs > ----- > > CMakeLists.txt ceb0b7768e894ed70528187d178b0979a90754f5 > account-status-helper.h PRE-CREATION > account-status-helper.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/126510/diff/ > > > Testing > ------- > > Compile, run. > > > Thanks, > > James Smith > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
