> On March 3, 2016, 10:48 p.m., David Edmundson wrote: > > account-status-helper.cpp, line 274 > > <https://git.reviewboard.kde.org/r/126510/diff/1/?file=445019#file445019line274> > > > > else if KTp::Presence(m_requestedGlobalPresence).isValid() ?
Tp::SimplePresence has no isValid() check, so this wraps the Tp::SimplePresence in KTp::Presence to use its validator without using the result. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126510/#review93145 ----------------------------------------------------------- On March 7, 2016, 6:50 a.m., James Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126510/ > ----------------------------------------------------------- > > (Updated March 7, 2016, 6:50 a.m.) > > > Review request for Telepathy. > > > Bugs: 284517 > http://bugs.kde.org/show_bug.cgi?id=284517 > > > Repository: ktp-kded-module > > > Description > ------- > > New features: > -Saves per-activity account presences between activities. > > > Diffs > ----- > > CMakeLists.txt ceb0b7768e894ed70528187d178b0979a90754f5 > account-status-helper.h PRE-CREATION > account-status-helper.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/126510/diff/ > > > Testing > ------- > > Compile, run. > > > Thanks, > > James Smith > >
_______________________________________________ KDE-Telepathy mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-telepathy
