> On Jan. 4, 2016, 6:06 p.m., Martin Klapetek wrote: > > Ship It! > > Tobias Berner wrote: > Could you commit it for me? Thanks. > > Martin Klapetek wrote: > Reviewboard seems to have lost this patch, can you please email it to me > directly? > > Thanks
How did this end? - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126602/#review90583 ----------------------------------------------------------- On Jan. 2, 2016, 12:25 p.m., Tobias Berner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126602/ > ----------------------------------------------------------- > > (Updated Jan. 2, 2016, 12:25 p.m.) > > > Review request for Telepathy. > > > Repository: telepathy-logger-qt > > > Description > ------- > > The cmake module file cmake/modules/FindGObject.cmake uses pkgconfig. > Therefore > the library returned in GOBJECT_LIBRARY does not contain the absolute path. > > This makes linking fail with > | [ 91%] Linking CXX shared library libtelepathy-logger-qt.so > | /usr/bin/ld: cannot find -lgobject-2.0 > > This patch extend FindGObject.cmake to also export GOBJECT_LIBRARY_DIRS as > provided by pkgconfig, and adding it to the link_directories in > TelepathyLoggerQt/CMakeLists.txt > > > This probably is not the most elegant way to fix the issue... > > > Diffs > ----- > > TelepathyLoggerQt/CMakeLists.txt 9790bdf > cmake/modules/FindGObject.cmake 1507b43 > > Diff: https://git.reviewboard.kde.org/r/126602/diff/ > > > Testing > ------- > > build locally. > > > Thanks, > > Tobias Berner > >
