> On Aug. 29, 2016, 3:45 p.m., Alexandr Akulich wrote: > > Tobias, is this still needed? It looks like we need to apply the same patch > > to TelepathyQt too. I would like to ship this and to make a similar commit > > to TpQt, but I can't test it. What do you think?
Since there's been no answer in 6 months i'll just discard this in two weeks to try to keep the queue cleaner. - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126602/#review98770 ----------------------------------------------------------- On Aug. 17, 2016, 7:03 p.m., Tobias Berner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126602/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2016, 7:03 p.m.) > > > Review request for Telepathy. > > > Repository: telepathy-logger-qt > > > Description > ------- > > The cmake module file cmake/modules/FindGObject.cmake uses pkgconfig. > Therefore > the library returned in GOBJECT_LIBRARY does not contain the absolute path. > > This makes linking fail with > | [ 91%] Linking CXX shared library libtelepathy-logger-qt.so > | /usr/bin/ld: cannot find -lgobject-2.0 > > This patch extend FindGObject.cmake to also export GOBJECT_LIBRARY_DIRS as > provided by pkgconfig, and adding it to the link_directories in > TelepathyLoggerQt/CMakeLists.txt > > > This probably is not the most elegant way to fix the issue... > > > Diffs > ----- > > TelepathyLoggerQt/CMakeLists.txt 9790bdf > cmake/modules/FindGObject.cmake 1507b43 > > Diff: https://git.reviewboard.kde.org/r/126602/diff/ > > > Testing > ------- > > build locally. > > > Thanks, > > Tobias Berner > >
