----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128954/#review99301 -----------------------------------------------------------
KTp/Declarative/messages-model.cpp (line 221) <https://git.reviewboard.kde.org/r/128954/#comment66862> I'd remove the comment, I'd say it's obvious that this needs to be iterated backwards. KTp/Declarative/messages-model.cpp (line 222) <https://git.reviewboard.kde.org/r/128954/#comment66861> Use iterators? - Aleix Pol Gonzalez On Sept. 20, 2016, 11:51 a.m., Alexandr Akulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128954/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2016, 11:51 a.m.) > > > Review request for Telepathy. > > > Repository: ktp-common-internals > > > Description > ------- > > Implemented message sort by sent timestamp (if available). > > This fixes order of scrollback messages. > > > Diffs > ----- > > KTp/Declarative/messages-model.cpp dc1088c > > Diff: https://git.reviewboard.kde.org/r/128954/diff/ > > > Testing > ------- > > Works, fixes the issue. > > > Thanks, > > Alexandr Akulich > >
