> On Sept. 20, 2016, 12:06 p.m., Aleix Pol Gonzalez wrote: > > KTp/Declarative/messages-model.cpp, line 222 > > <https://git.reviewboard.kde.org/r/128954/diff/1/?file=477161#file477161line222> > > > > Use iterators? > > Alexandr Akulich wrote: > How to get an index from iterator?
You can count in parallel without calling `QList::operator[]` on the index. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128954/#review99301 ----------------------------------------------------------- On Sept. 20, 2016, 11:51 a.m., Alexandr Akulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128954/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2016, 11:51 a.m.) > > > Review request for Telepathy. > > > Repository: ktp-common-internals > > > Description > ------- > > Implemented message sort by sent timestamp (if available). > > This fixes order of scrollback messages. > > > Diffs > ----- > > KTp/Declarative/messages-model.cpp dc1088c > > Diff: https://git.reviewboard.kde.org/r/128954/diff/ > > > Testing > ------- > > Works, fixes the issue. > > > Thanks, > > Alexandr Akulich > >
