> On Sept. 21, 2016, 9:19 a.m., Martin Klapetek wrote: > > > Use c++11 for loops instead of Q_FOREACH for new code. > > > > Please don't do that, it's slow. See > > http://www.dvratil.cz/2015/06/qt-containers-and-c11-range-based-loops/ for > > more details. > > > > That said, I still don't agree with this patch. > > Alexandr Akulich wrote: > qAsConst?
Q_FOREACH is going away, and we iterate over a really small number of values anyway. Also, everything looks already const or is unshared, so there's no actual need for qAsConst(). - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123504/#review99369 ----------------------------------------------------------- On Sept. 17, 2016, 4:03 p.m., James Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123504/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2016, 4:03 p.m.) > > > Review request for Telepathy and Martin Klapetek. > > > Repository: ktp-kded-module > > > Description > ------- > > New features: > -Much improved multiple player handling; a number of service availability > bugs were fixed. > -Ignore tracks with inadequate metadata > -Separator for empty metadata info fields with (currently) hidden config > > > Diffs > ----- > > telepathy-mpris.h 05b77c90a50372fd9ed66bde0ab8a287caf34b51 > telepathy-mpris.cpp ee0e622c68bdd156e45914f542d2fe13f0ddb610 > > Diff: https://git.reviewboard.kde.org/r/123504/diff/ > > > Testing > ------- > > Compile, run. > > > Thanks, > > James Smith > >
