> On Sept. 23, 2016, 1:03 p.m., Alexandr Akulich wrote: > > telepathy-mpris.cpp, line 96 > > <https://git.reviewboard.kde.org/r/123504/diff/5/?file=477191#file477191line96> > > > > Here you're iterating over non-const list of dbus services (usually > > 60-100 entries). > > James Smith wrote: > According to the documentation this is const. > > Alexandr Akulich wrote: > According to the documentation, this is type T, which is > ```QStringList``` for ```QDBusPendingReply<QStringList>```, which is not > const. (I'm not about constness of the QDBusPendingReply::value() method, but > about the type of container in the ```for```. We have ```for (const QString & > : QStringList)``` here. Container is not const, so iteration will cause > detach. Correct me, if I'm wrong.
There is a typical rvalue and this is what qAsConst can be for. - Alexandr ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123504/#review99480 ----------------------------------------------------------- On Sept. 23, 2016, 5:41 a.m., James Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123504/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2016, 5:41 a.m.) > > > Review request for Telepathy and Martin Klapetek. > > > Repository: ktp-kded-module > > > Description > ------- > > New features: > -Much improved multiple player handling; a number of service availability > bugs were fixed. > -Ignore tracks with inadequate metadata > -Separator for empty metadata info fields with (currently) hidden config > > > Diffs > ----- > > telepathy-mpris.h 05b77c90a50372fd9ed66bde0ab8a287caf34b51 > telepathy-mpris.cpp ee0e622c68bdd156e45914f542d2fe13f0ddb610 > > Diff: https://git.reviewboard.kde.org/r/123504/diff/ > > > Testing > ------- > > Compile, run. > > > Thanks, > > James Smith > >