Christian Ehrlicher schrieb:
Patrick Spendrin schrieb:
Ok additionally to the rest, I experienced an internal compiler error on mingw. I spoke with the windows gcc maintainer Aaron LaFramboise and he said that the error is fixed in more recent gcc versions (upcoming 4.2/4.3 versions) and that it would be hard to fix gcc 3 on our own.
Thus I removed the inline'd ctors/dtors and fixed the one linker error.

As I don't want to interfere with somebody else, please say whether I can commit.

Did you try moving them into the class definition?
Seems to work, changed patch attached.


Christian
Patrick


------------------------------------------------------------------------

_______________________________________________
Kde-windows mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-windows


--
web:                 http://windows.kde.org
mailing list:        [email protected]
irc:                 #kde-windows (irc.freenode.net)
Index: core/ksection.h
===================================================================
--- core/ksection.h	(revision 807835)
+++ core/ksection.h	(working copy)
@@ -48,10 +48,10 @@
      * @param startIndex starting index
      * @param endIndex end index
      */
-    KSection( int startIndex, int endIndex );
-    KSection( const KSection &other );
-    KSection();
-    ~KSection();
+    KSection( int startIndex, int endIndex ) {};
+    KSection( const KSection &other ) {};
+    KSection() {};
+    ~KSection() {};
 
   public:
     KSection &operator=( const KSection &other );
@@ -125,11 +125,6 @@
 inline KSection KSection::fromWidth( int startIndex, int width ) { return KSection(startIndex,startIndex+width-1); }
 inline KSection KSection::fromWidth( int width ) { return KSection(0,width-1); }
 
-inline KSection::KSection( int startIndex, int endIndex ) : KRange<int>(startIndex,endIndex) {}
-inline KSection::KSection( const KSection &other ) : KRange<int>(other.start(),other.end()) {}
-inline KSection::KSection()  {}
-inline KSection::~KSection() {}
-
 inline bool KSection::operator==( const KSection &other ) const { return KRange<int>::operator==(other); }
 
 inline KSection &KSection::operator=( const KSection &other ) { KRange<int>::operator=(other); return *this; }
Index: gui/test/CMakeLists.txt
===================================================================
--- gui/test/CMakeLists.txt	(revision 807835)
+++ gui/test/CMakeLists.txt	(working copy)
@@ -38,7 +38,7 @@
 
 kde4_add_unit_test(coordrangetest TESTNAME libokteta-gui-coordrangetest  ${coordrangetest_SRCS})
 
-target_link_libraries(coordrangetest  ${KDE4_KDECORE_LIBS} ${QT_QTTEST_LIBRARY})
+target_link_libraries(coordrangetest  ${KDE4_KDECORE_LIBS} ${QT_QTTEST_LIBRARY} oktetacore )
 
 
 ########### next target ###############
_______________________________________________
Kde-windows mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-windows

Reply via email to