Friedrich W. H. Kossebau schrieb:
Hi Patrick,
Am Donnerstag, 15. Mai 2008, um 17:34 Uhr, schrieb Patrick Spendrin:
Christian Ehrlicher schrieb:
Patrick Spendrin schrieb:
Ok additionally to the rest, I experienced an internal compiler error
on mingw. I spoke with the windows gcc maintainer Aaron LaFramboise
and he said that the error is fixed in more recent gcc versions
(upcoming 4.2/4.3 versions) and that it would be hard to fix gcc 3 on
our own.
Thus I removed the inline'd ctors/dtors and fixed the one linker error.
As I don't want to interfere with somebody else, please say whether I
can commit.
Did you try moving them into the class definition?
Seems to work, changed patch attached.
--- 8< ---
+ KSection( int startIndex, int endIndex ) {};
+ KSection( const KSection &other ) {};
+ KSection() {};
+ ~KSection() {};
--- 8< ---
You may want to use the complete instructions for the parameterized
constructors, not just "{}". And the trailing ";" should go away.
Please also add a comment that this is a workaround for gcc 3 on windows, so I
know when to clean it up again. :)
ok, fixed, so you can commit in the end.
--- 8< ---
--- gui/test/CMakeLists.txt (revision 807835)
+++ gui/test/CMakeLists.txt (working copy)
@@ -38,7 +38,7 @@
kde4_add_unit_test(coordrangetest TESTNAME libokteta-gui-coordrangetest
${coordrangetest_SRCS})
-target_link_libraries(coordrangetest ${KDE4_KDECORE_LIBS}
${QT_QTTEST_LIBRARY})
+target_link_libraries(coordrangetest ${KDE4_KDECORE_LIBS}
${QT_QTTEST_LIBRARY} oktetacore )
--- 8< ---
Why is this needed?
hm, there was an error back then :-/ it vanished.
Other than that for the moved ctors/dtors in ksection.h please go ahead if
this helps with mingw.
no the rest is ok, but the ctor/dtor thing would make it rather
impossible to build.
Cheers
Friedrich
regards,
Patrick
_______________________________________________
Kde-windows mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-windows
--
web: http://windows.kde.org
mailing list: [email protected]
irc: #kde-windows (irc.freenode.net)
Index: core/ksection.h
===================================================================
--- core/ksection.h (revision 807835)
+++ core/ksection.h (working copy)
@@ -48,10 +48,12 @@
* @param startIndex starting index
* @param endIndex end index
*/
- KSection( int startIndex, int endIndex );
- KSection( const KSection &other );
- KSection();
- ~KSection();
+ // FIXME: gcc 3.4.5 on windows gives an internal_compiler_error if ctor/dtor are defined with the keyword inline
+ // thus put the function bodies here
+ KSection( int startIndex, int endIndex ) : KRange<int>(startIndex,endIndex) {}
+ KSection( const KSection &other ) : KRange<int>(other.start(),other.end()) {}
+ KSection() {}
+ ~KSection() {}
public:
KSection &operator=( const KSection &other );
@@ -125,11 +127,6 @@
inline KSection KSection::fromWidth( int startIndex, int width ) { return KSection(startIndex,startIndex+width-1); }
inline KSection KSection::fromWidth( int width ) { return KSection(0,width-1); }
-inline KSection::KSection( int startIndex, int endIndex ) : KRange<int>(startIndex,endIndex) {}
-inline KSection::KSection( const KSection &other ) : KRange<int>(other.start(),other.end()) {}
-inline KSection::KSection() {}
-inline KSection::~KSection() {}
-
inline bool KSection::operator==( const KSection &other ) const { return KRange<int>::operator==(other); }
inline KSection &KSection::operator=( const KSection &other ) { KRange<int>::operator=(other); return *this; }
_______________________________________________
Kde-windows mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-windows
