----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6424/#review9765 -----------------------------------------------------------
Ship it! looks good - ralf.habacker On Jan. 30, 2011, 1:26 p.m., Wolfgang Rohdewald wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6424/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2011, 1:26 p.m.) > > > Review request for kde-windows. > > > Summary > ------- > > This eliminates code duplication. > And it makes sure that the files are closed after being written. Until now, > they were not closed at all. > Writing a file and not closing it is not recommended. It is implementation > dependent if and when the > data will actually be written. > > > Diffs > ----- > > /trunk/kdesupport/emerge/bin/utils.py 1217952 > > Diff: http://svn.reviewboard.kde.org/r/6424/diff > > > Testing > ------- > > > Thanks, > > Wolfgang > >
_______________________________________________ Kde-windows mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-windows
