----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/7010/#review10886 -----------------------------------------------------------
trunk/KDE/kdegames/kbattleship/src/battlefieldview.h <http://svn.reviewboard.kde.org/r/7010/#comment13516> I am unsure about this one. Apparently, there are such things in a non-conditional part of the upstream Qt codebase. I am afraid, someone needs to investigate why it works over there. trunk/KDE/kdegames/libkdegames/CMakeLists.txt <http://svn.reviewboard.kde.org/r/7010/#comment13517> Oh, I have just tried to push the issues I raised on the mailing list including this one. trunk/KDE/kdegames/libkdegames/kgthemeprovider.cpp <http://svn.reviewboard.kde.org/r/7010/#comment13518> To be honest, if you are at sanitizing this line, I would also use .first() instead of [0], but I can do in a follow up patch as well. - Laszlo Papp On July 24, 2012, 10:34 p.m., Andrius Ribas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/7010/ > ----------------------------------------------------------- > > (Updated July 24, 2012, 10:34 p.m.) > > > Review request for kde-windows and KDE Games. > > > Description > ------- > > General small fixes to enable build. Comments on each item. > > > Diffs > ----- > > trunk/KDE/kdegames/kbattleship/src/battlefieldview.h 1307602 > trunk/KDE/kdegames/libkdegames/CMakeLists.txt 1307602 > trunk/KDE/kdegames/libkdegames/kgthemeprovider.cpp 1307602 > > Diff: http://svn.reviewboard.kde.org/r/7010/diff/ > > > Testing > ------- > > Tested using MSVC 2010. > > > Thanks, > > Andrius Ribas > >
_______________________________________________ Kde-windows mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-windows
