----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/7010/#review10887 -----------------------------------------------------------
Ship it! I would have personally preferred the camelCase const variable names instead of the low-level macro'ish, but since it has already been like that, it is ok to go with this one, I believe. - Laszlo Papp On July 24, 2012, 11:58 p.m., Andrius Ribas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/7010/ > ----------------------------------------------------------- > > (Updated July 24, 2012, 11:58 p.m.) > > > Review request for kde-windows and KDE Games. > > > Description > ------- > > General small fixes to enable build. Comments on each item. > > > Diffs > ----- > > trunk/KDE/kdegames/kbattleship/src/battlefieldview.h 1307634 > trunk/KDE/kdegames/kbattleship/src/battlefieldview.cpp 1307634 > trunk/KDE/kdegames/libkdegames/kgthemeprovider.cpp 1307634 > > Diff: http://svn.reviewboard.kde.org/r/7010/diff/ > > > Testing > ------- > > Tested using MSVC 2010. > > > Thanks, > > Andrius Ribas > >
_______________________________________________ Kde-windows mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-windows
