Fixes Coverity CID 709275: Unchecked return value (CHECKED_RETURN)
Calling function "QDomDocument::setContent(QIODevice *, QString *, int *, int 
*)" without checking return value (as is done elsewhere 6 out of 7 times).
No check of the return value of "doc.setContent(&file, NULL, NULL, NULL)".
134            doc.setContent(&file);
---
 src/dvdwizardvob.cpp |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/dvdwizardvob.cpp b/src/dvdwizardvob.cpp
index ebc4b84..1caae7f 100644
--- a/src/dvdwizardvob.cpp
+++ b/src/dvdwizardvob.cpp
@@ -131,7 +131,10 @@ void DvdWizardVob::slotAddVobFile(KUrl url, const QString 
&chapters)
         QFile file(url.path() + ".dvdchapter");
         if (file.open(QIODevice::ReadOnly)) {
             QDomDocument doc;
-            doc.setContent(&file);
+            if (doc.setContent(&file) == false) {
+                file.close();
+                return;
+            }
             file.close();
             QDomNodeList chapters = doc.elementsByTagName("chapter");
             QStringList chaptersList;
-- 
1.7.10.4


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Kdenlive-devel mailing list
Kdenlive-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kdenlive-devel

Reply via email to